DBP: macOS - Scheduler Progress Notifications #2023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jotaemepereira
requested changes
Jan 5, 2024
There was a problem hiding this comment.
@Bunn I was able to fire all notifications, awesome work 🎉 . I’m requesting changes because of the following:
When I receive a notification that scans were removed and I open the DBP tab and tap on the notification, nothing will happen; the UI stays like scans are still in progress. We need to reload the tab if it is present when the notification is tapped.
I’ve also added some questions.
Feel free to dismiss my request for changes after I’m OOO
...tection/Sources/DataBrokerProtection/Operations/DataBrokerProfileQueryOperationManager.swift
Show resolved
Hide resolved
...ces/DataBrokerProtection/UserNotifications/DataBrokerProtectionUserNotificationService.swift
Show resolved
Hide resolved
...tection/Sources/DataBrokerProtection/Operations/DataBrokerProfileQueryOperationManager.swift
Show resolved
Hide resolved
|
Task with PR review follow up: https://app.asana.com/0/0/1206298053191001/f |
samsymons
added a commit
that referenced
this pull request
Jan 8, 2024
* main: (35 commits) Update login item failure pixel (#2024) fix turn off sync error message (#2025) DBP: macOS - Scheduler Progress Notifications (#2023) DBP: Implement sign-out flow for DBP (#2009) Switch CI to Xcode 15.1 (#2022) fix(duckplayer): bump CSS for duckplayer nav loop fix (#1982) Bump Submodules/privacy-reference-tests from `a3acc21` to `6b7ad1e` (#2006) Bump version to 1.69.0 (99) DBP: Respect foreign constraints when deleting all user's data (#2014) DBP: Respect foreign constraints when deleting all user's data (#2014) Don't force reload tab when restoring state (#2016) Bump version to 1.69.0 (98) Update embedded files Update NetP launch agent logic to include build number (#2015) Always use 'sandbox' Application Support directory for Favicons Fetcher (#2013) Allow calculations in the address bar (#2012) Fix clickable area for buttons in 'Sync with Another Device' view (#2011) Fix for empty autofill state displayed on top of existing password items (#1998) Update error messages (#1999) Autofill never save for site (#1991) ...
samsymons
added a commit
that referenced
this pull request
Jan 9, 2024
# By Dax the Duck (6) and others # Via Fernando Bunn (2) and others * main: (36 commits) Send VPN system extension crashes to Sentry (#2002) Update login item failure pixel (#2024) fix turn off sync error message (#2025) DBP: macOS - Scheduler Progress Notifications (#2023) DBP: Implement sign-out flow for DBP (#2009) Switch CI to Xcode 15.1 (#2022) fix(duckplayer): bump CSS for duckplayer nav loop fix (#1982) Bump Submodules/privacy-reference-tests from `a3acc21` to `6b7ad1e` (#2006) Bump version to 1.69.0 (99) DBP: Respect foreign constraints when deleting all user's data (#2014) DBP: Respect foreign constraints when deleting all user's data (#2014) Don't force reload tab when restoring state (#2016) Bump version to 1.69.0 (98) Update embedded files Update NetP launch agent logic to include build number (#2015) Always use 'sandbox' Application Support directory for Favicons Fetcher (#2013) Allow calculations in the address bar (#2012) Fix clickable area for buttons in 'Sync with Another Device' view (#2011) Fix for empty autofill state displayed on top of existing password items (#1998) Update error messages (#1999) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo/Statistics/PixelEvent.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1204684997648613/f
Description:
Steps to test this PR:
macos-browser/LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/UserNotifications/DataBrokerProtectionUserNotificationService.swift
Line 74 in 07b42d1
To something like this:
This will simulate all profiles being removed.